-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement/revamp cursor iteration #44
base: master
Are you sure you want to change the base?
Improvement/revamp cursor iteration #44
Commits on Oct 17, 2019
-
Modify cursor.__iter__ to use a local copy of skip, so the original v…
…alue set by the user is not lost. Also, fix a bug where a second iteration on the cursor would results in no content at all, because of self.retrieved not being reset. This is not an useful information outside of the iteration algo so self.retrieved was made local to reduce impact. Adding .vscode in .gitignore
Configuration menu - View commit details
-
Copy full SHA for 20a43a1 - Browse repository at this point
Copy the full SHA 20a43a1View commit details
Commits on Oct 18, 2019
-
Merge branch 'master' of github.com:shnups/appnexus-client into fix/c…
…ursor-skip-retrieved
Configuration menu - View commit details
-
Copy full SHA for 61dc775 - Browse repository at this point
Copy the full SHA 61dc775View commit details -
Fix the computation of start_element in gen_random_collection() in te…
…sts/helpers.py. The last page generated was not getting the right start_element and causing a StopIteration when the generated collection was assigned as a side_effect on a cursor.
Configuration menu - View commit details
-
Copy full SHA for 5915e13 - Browse repository at this point
Copy the full SHA 5915e13View commit details
Commits on Oct 21, 2019
-
Revamp the algorithm on the cursor on how it determines which query t…
…o made. The logic handling skip (if defined) and limit (if defined) has been transfered from __iter__ to iter_pages to avoid unecessary round-trips with AppNexus API. Add unit tests around that logic and revamp of the helpers that generate collections when mocking client.get results.
Configuration menu - View commit details
-
Copy full SHA for ae6993d - Browse repository at this point
Copy the full SHA ae6993dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 18dd233 - Browse repository at this point
Copy the full SHA 18dd233View commit details
Commits on Sep 27, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 60b82b7 - Browse repository at this point
Copy the full SHA 60b82b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c671cb - Browse repository at this point
Copy the full SHA 8c671cbView commit details -
Remove unused fixture and parameters with default values when calling…
… mock_ordered_cursor
Configuration menu - View commit details
-
Copy full SHA for 2deb232 - Browse repository at this point
Copy the full SHA 2deb232View commit details