Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/revamp cursor iteration #44

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Commits on Oct 17, 2019

  1. Modify cursor.__iter__ to use a local copy of skip, so the original v…

    …alue set by the user is not lost.
    
    Also, fix a bug where a second iteration on the cursor would results in no content at all, because of self.retrieved not being reset. This is not an useful information outside of the iteration algo so self.retrieved was made local to reduce impact.
    Adding .vscode in .gitignore
    shnups committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    20a43a1 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2019

  1. Merge branch 'master' of github.com:shnups/appnexus-client into fix/c…

    …ursor-skip-retrieved
    shnups committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    61dc775 View commit details
    Browse the repository at this point in the history
  2. Fix the computation of start_element in gen_random_collection() in te…

    …sts/helpers.py.
    
    The last page generated was not getting the right start_element and causing a StopIteration when the generated collection was assigned as a side_effect on a cursor.
    shnups committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    5915e13 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2019

  1. Revamp the algorithm on the cursor on how it determines which query t…

    …o made.
    
    The logic handling skip (if defined) and limit (if defined) has been transfered from __iter__ to iter_pages to avoid unecessary round-trips with AppNexus API.
    Add unit tests around that logic and revamp of the helpers that generate collections when mocking client.get results.
    shnups committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    ae6993d View commit details
    Browse the repository at this point in the history
  2. Address flake8 issues in CI

    shnups committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    18dd233 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2020

  1. Configuration menu
    Copy the full SHA
    60b82b7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8c671cb View commit details
    Browse the repository at this point in the history
  3. Remove unused fixture and parameters with default values when calling…

    … mock_ordered_cursor
    shnups committed Sep 27, 2020
    Configuration menu
    Copy the full SHA
    2deb232 View commit details
    Browse the repository at this point in the history