Missing dependency zlib or more in external/common/include
#48
Comments
|
Good catch. @david-ragazzi what do you think? |
|
I believe this can be done by CMake command |
|
Oh no, it's not the reason I thought. While trying to locate a place to put set(LIB_STATIC_Z z)
add_library(${LIB_STATIC_Z} STATIC IMPORTED)
set_property(TARGET ${LIB_STATIC_Z} PROPERTY IMPORTED_LOCATION "${REPOSITORY_DIR}/external/${NTA_PLATFORM_OS}/lib/libz.${STATIC_LIB_EXTENSION}")And in line 351, it reads: #
# Include directories of headers
# Allows us to find includes for external libraries and enables
# #include <nta/common/...>
#
set(NTA_INCLUDEFLAGS "-I${REPOSITORY_DIR} -I${PROJECT_BUILD_RELEASE_DIR}/include -isystem${REPOSITORY_DIR}/external/common/include -isystem${REPOSITORY_DIR}/external/${NTA_PLATFORM_OS}/include")I've checkd |
@utensil The headers also are provided at external/common/include. |
Actually I think we should continue using the static libraries located at external folder. This avoid several issues of compatibility and yet help the user saving a time that would be spent downloading them (and compiling them, in case of Windows)... |
|
@david-ragazzi commented 6 hours ago
This comment leads me to find in https://github.com/numenta/nupic/tree/master/external/common/include , |
|
There're also other headers missing:
I understand some of them should be removed to minimize the dependency, and was removed intentionally in #47 . This raised 2 questions:
I'll look into them. |
|
It seems this should be fixed before merging numenta/nupic-legacy#751 . |
|
On Fri, Apr 4, 2014 at 3:00 AM, utensil notifications@github.com wrote:
|
|
You guys are talking C-talk, which is still Greek to me, so let me know if you need help. 😉 |
I don't include these headers propositally, as nupic.core don't need these libraries.. I tested the remotion of each one to see which library is used or not by nupic.core.. |
|
@david-ragazzi Removing a header and see if the build fails is not enough. I'll further verify other headers. |
|
But I didn't remove zlib headers.. Furthermore, I removed the headers and also the static libraries for test them.. |
|
@david-ragazzi , you did remove zlib headers, as the diff shows: Is it that you had kept it locally, but did not commit? |
|
@david-ragazzi please check this, this issue remains valid. |
|
I've reproduced this issue on travis, see https://travis-ci.org/utensil/nupic.core/jobs/24867408 : By removing |
utensil
changed the title
zlibzlib or more in external/common/include
|
I had to delete zlib.h to get this to build. |
|
@olavks Can you describe your OS, compiler? As for why providing the |
|
@olavks I've opened an issue for you problem, let's discuss it further there. |
UPDATE
Original issue
While trying to give merged #47 a try in a koding.com VM(which is basically a Ubuntu variant) using
gcc version 4.7.3 (Ubuntu/Linaro 4.7.3-1ubuntu1)andnumenta/nupic.core's master@HEAD, I got the following compilation error:It's trivial to fix it by
sudo apt-get install zlibc zlib1g zlib1g-devunder Ubuntu, but this got me thinking, should CMake do some extra dependency checks? Don't know if there's any other dependencies, because I tried cleaning the VM environment and no other dependency problems surfaced.cc @david-ragazzi @rhyolight
The text was updated successfully, but these errors were encountered: