This repository has been archived by the owner on Sep 1, 2023. It is now read-only.
Recover zlib.h in external
#97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@david-ragazzi @breznak Please review, #48 has become an ancient issue now. solving it is a relieve 😄 |
|
There's a few weird things though:
|
|
Still needs review. |
|
@rhyolight This PR is ready to merge. Can you assign this PR to a reviewer? This is a trivial issue but valid for quite long. |
|
I think @david-ragazzi and @breznak are out right now, so @scottpurdy can you take a look? |
scottpurdy
added a commit
that referenced
this pull request
May 20, 2014
Recover `zlib.h` in `external`
This was referenced Jun 6, 2014
breznak
added a commit
to breznak/nupic.core
that referenced
this pull request
Nov 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48 .
zlibor more inexternal/common/include#48 is reproduced on travis by this commit, see the travis build for itzlibor more inexternal/common/include#48 is fixed by recoveringzlib.hinexternalfrom 46835bf, right before merging Independent Build Process #47 which caused Missing dependencyzlibor more inexternal/common/include#48