Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved icon for CuteCom #3401

Merged
merged 8 commits into from
Sep 17, 2016
Merged

Improved icon for CuteCom #3401

merged 8 commits into from
Sep 17, 2016

Conversation

Jacajack
Copy link
Contributor

@Jacajack Jacajack commented Sep 1, 2016

Hi!

Normally CuteCom uses same icon as terminal, which causes a lot of confusion, at least in my case, because 100% of the time I click the opposite of what I want...

image

This is the icon I made:
selection_867

Only thing that worries me is that desktop file wants to use openterm icon, which is linked to the terminal icon.

This is the content of /usr/share/applications/kde/cutecom.desktop

[Desktop Entry]
Encoding=UTF-8
Name=CuteCom
MimeType=
GenericName=Serial Terminal
Exec=cutecom
Icon=openterm
Path=
Type=Application
Terminal=0
X-KDE-StartupNotify=false

Does it count as a hardcoded icon? If so, what can I do with it?

@Foggalong Foggalong added the merge label Sep 1, 2016
@Foggalong
Copy link
Contributor

What does CuteCom do?

@palob
Copy link
Member

palob commented Sep 1, 2016

@Jacajack Please do a git pull to update your fork. You are still pushing your new icon inside the old directory structure.

@Jacajack
Copy link
Contributor Author

Jacajack commented Sep 1, 2016

@Foggalong, it's a serial terminal, this is how it looks:
cutecom_880

Icon represents DB9 connector, which is used for RS232 serial communication standard.
image

@palob Whoops... I didn't notice that something has changed. Let me try to fix it

@palob
Copy link
Member

palob commented Sep 1, 2016

Is there any app named openterm?

@Jacajack
Copy link
Contributor Author

Jacajack commented Sep 1, 2016

@palob Uh... That's exactly what I was thinking about. Google search for openterm doesn't return any useful information. Maybe it's just old/other name for CuteCom?

So, can I remove the openterm symlink, and call my icon like this?
Alright, I guess symlinks don't exist here anymore

@Foggalong
Copy link
Contributor

Foggalong commented Sep 2, 2016

Found this. It appears to be something to do with konsole, and our icon originally came from the faenza commit. I'd recommend appealing to the CuteCom developers to change their icon line to a name unique to their app.

@Jacajack
Copy link
Contributor Author

Jacajack commented Sep 2, 2016

@Foggalong I asked about that. To be honest, posts on that forum are 14 years old. Are you sure that they are still up to date?

@Foggalong
Copy link
Contributor

Foggalong commented Sep 2, 2016

@Jacajack Honestly no idea since it's a while since I dabbled with KDE. It's most probable that Konsole has long since changed it's icon line from openterm. It wouldn't be the first time that we've had to change something because we picked up an archaic icon from Faenza. However it's also inadvisable that CuteCom pick an icon name the same as that of another program, however old the latter may be.

@Jacajack
Copy link
Contributor Author

Alright, since CuteCom now refers to cutecom icon (neundorf/CuteCom#12 and neundorf/CuteCom#11), I changed icon name to cutecom.svg.

Copy link
Contributor

@Foggalong Foggalong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, now we can move on to the actual icon. It all looks good to me, except the circles in the middle section aren't aligned to grid.

screenshot_2016-09-16_18-09-41

If you change them to the above pattern, then as you can see below it makes the icon way less blury.

screenshot_2016-09-16_18-10-27

Copy link
Contributor

@Foggalong Foggalong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may have done this to make the circles evenly spaced within the grey inner section. In this case I'd recommend extending the inner and outer grey sections by 1px vertically.

@Jacajack
Copy link
Contributor Author

@Foggalong, yep, that's exactly what it was for. I rescaled the background part as you advised me to do and aligned the circles. Honesty, the version you presented above (with only circles aligned) also looks good, and at first I didn't even realize that they were not centered along Y axis.

@Foggalong Foggalong merged commit a27c561 into numixproject:master Sep 17, 2016
@Jacajack Jacajack deleted the cutecom-icon branch September 17, 2016 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants