Weather tile #542
Merged
Weather tile #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no specific mapping is defined for a type, just look for an id property. This prevents having to define a lookup function for any new tile type, where we can use the id property as a canonical id.
Rather than defaulting it in the search details component, default it as part of the global default state. This is needed because the departure date also needs to be available in order to render a weather tile. If it is only defaulted at a component level then it would need to be replicated twice. By setting it at a global level then it only needs to be set once.
Passes the minimum data into a new weather tile component to do basic proff-of-concept rendering.
To prevent undefined function error being thrown
Having one file per image doesn't scale very well at all. Instead have a single constants file which defines the loaction of images within a common root location.
|
@lennym looks good! 👍 |
|
Note: this will need numo-labs/lambda-ne-weather-provider#3 to be merged and promoted to prod to work on non-CI environments. There is currently the dev version of the weather provider on CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is sufficient to display a very basic weather/climate tile which shows the average temperature for a destination during the month selected for departure.
The work to show the expanded data when clicking on the tile is ongoing, but it may be that we want to merge this as it is.
Example: