Skip to content
This repository has been archived by the owner on Jun 10, 2020. It is now read-only.

MAINT: add more functions to the blacklist #73

Merged
merged 2 commits into from
Jun 5, 2020
Merged

MAINT: add more functions to the blacklist #73

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf40758
MAINT: add more functions to the blacklist
person142 Apr 25, 2020
12528a9
MAINT: remove recfrom{csv,txt} from the blacklist
person142 Jun 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 15 additions & 1 deletion runtests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,22 @@
"numpy": {
# Stdlib modules in the namespace by accident
"absolute_import",
"division",
"print_function",
"warnings",
# Accidentally public
# Accidentally public, deprecated, or shouldn't be used
"Tester",
"add_docstring",
"add_newdoc",
"add_newdoc_ufunc",
"core",
"fastCopyAndTranspose",
"get_array_wrap",
"int_asbuffer",
"oldnumeric",
"safe_eval",
"set_numeric_ops",
"test",
# Builtins
"bool",
"complex",
Expand All @@ -41,6 +52,9 @@
"ppmt",
"pv",
"rate",
# More standard names should be preferred
"alltrue", # all
"sometrue", # any
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For alltrue can't we just use alltrue = all and call it a day?
Considering it's supposed to be public function (correct me if I'm wrong here) I feel it would not be wise to just skip it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering it's supposed to be public function

It's not in the refguide, and the general opinion seems to be "should be deprecated/removed" (see numpy/numpy#14584), so I think it's best to exclude it.

}
}

Expand Down