MAINT: add more functions to the blacklist #73
Conversation
runtests.py
Outdated
| "int_asbuffer", | ||
| "oldnumeric", | ||
| "recfromcsv", | ||
| "recfromtxt", |
There was a problem hiding this comment.
These two recfrom functions are the only ones I'm not sure about, they're not deprecated and are regular data loading functions. Why should they be ignored?
There was a problem hiding this comment.
I think I ignored them because they aren't in the refguide and because of numpy/numpy#12385 (comment). Happy to add them back though.
There was a problem hiding this comment.
Added the two recfrom functions back.
| @@ -41,6 +54,9 @@ | |||
| "ppmt", | |||
| "pv", | |||
| "rate", | |||
| # More standard names should be preferred | |||
| "alltrue", # all | |||
| "sometrue", # any | |||
There was a problem hiding this comment.
For alltrue can't we just use alltrue = all and call it a day?
Considering it's supposed to be public function (correct me if I'm wrong here) I feel it would not be wise to just skip it.
There was a problem hiding this comment.
Considering it's supposed to be public function
It's not in the refguide, and the general opinion seems to be "should be deprecated/removed" (see numpy/numpy#14584), so I think it's best to exclude it.
Found a few more functions that we shouldn't add types for.
person142
force-pushed
the
update-blacklist
branch
from
0d9b2c8
to
12528a9
Compare
|
Ok, the two questionable functions have been removed, so merging. |
Found a few more functions that we shouldn't add types for.