MNT: apply review comments

numpy · May 10, 2024 · 0a07582 · 0a07582
1 parent 16c292d
commit 0a07582
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/numpy/_core/src/umath/stringdtype_ufuncs.cpp b/numpy/_core/src/umath/stringdtype_ufuncs.cpp
@@ -1107,6 +1107,7 @@ string_lrstrip_chars_strided_loop(
             if (NpyString_pack(oallocator, ops, new_buf, new_buf_size) < 0) {
                 npy_gil_error(PyExc_MemoryError, "Failed to pack string in %s",
                               ufunc_name);
+                PyMem_RawFree(new_buf);
                 goto fail;
             }
 
@@ -1189,7 +1190,6 @@ string_lrstrip_whitespace_strided_loop(
         npy_static_string s = {0, NULL};
         int s_isnull = NpyString_load(allocator, ps, &s);
 
-
         if (s_isnull == -1) {
             npy_gil_error(PyExc_MemoryError, "Failed to load string in %s",
                           ufunc_name);

diff --git a/numpy/_core/tests/test_stringdtype.py b/numpy/_core/tests/test_stringdtype.py
@@ -1503,8 +1503,7 @@ def test_setup(self):
         view = self.get_view(self.a)
         sizes = np.where(is_short, view['size_and_flags'] & 0xf,
                          view['size'])
-        assert_array_equal(sizes, np.strings
-                           .str_len(self.a))
+        assert_array_equal(sizes, np.strings.str_len(self.a))
         assert_array_equal(view['xsiz'][2:],
                            np.void(b'\x00' * (self.sizeofstr // 4 - 1)))
         # Check that the medium string uses only 1 byte for its length