Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
BUG: Fix
np.array_api.can_cast()
by not relying on np.can_cast()
- Loading branch information
Showing
3 changed files
with
58 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import pytest | ||
|
||
from numpy import array_api as xp | ||
|
||
|
||
@pytest.mark.parametrize( | ||
"from_, to, expected", | ||
[ | ||
(xp.int8, xp.int16, True), | ||
(xp.int16, xp.int8, False), | ||
# np.can_cast has discrepancies with the Array API | ||
# See https://github.com/numpy/numpy/issues/20870 | ||
(xp.bool, xp.int8, False), | ||
(xp.asarray(0, dtype=xp.uint8), xp.int8, False), | ||
], | ||
) | ||
def test_can_cast(from_, to, expected): | ||
""" | ||
can_cast() returns correct result | ||
""" | ||
assert xp.can_cast(from_, to) == expected |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
from typing import Callable | ||
|
||
import pytest | ||
|
||
from numpy import array_api as xp | ||
|
||
|
||
def p(func: Callable, *args, **kwargs): | ||
f_sig = ", ".join( | ||
[str(a) for a in args] + [f"{k}={v}" for k, v in kwargs.items()] | ||
) | ||
id_ = f"{func.__name__}({f_sig})" | ||
return pytest.param(func, args, kwargs, id=id_) | ||
|
||
|
||
@pytest.mark.parametrize( | ||
"func, args, kwargs", | ||
[ | ||
p(xp.can_cast, 42, xp.int8), | ||
p(xp.can_cast, xp.int8, 42), | ||
p(xp.result_type, 42), | ||
], | ||
) | ||
def test_raises_on_invalid_types(func, args, kwargs): | ||
"""Function raises TypeError when passed invalidly-typed inputs""" | ||
with pytest.raises(TypeError): | ||
func(*args, **kwargs) |