Skip to content

Commit

Permalink
Release 1.7.0b2
Browse files Browse the repository at this point in the history
  • Loading branch information
@certik
certik committed Sep 20, 2012
1 parent 50f71cb commit f217517
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions setup.py
View file
Expand Up @@ -57,8 +57,8 @@
MAJOR = 1
MINOR = 7
MICRO = 0
ISRELEASED = False
VERSION = '%d.%d.%drc1' % (MAJOR, MINOR, MICRO)
ISRELEASED = True
VERSION = '%d.%d.%db2' % (MAJOR, MINOR, MICRO)

# Return the git revision as a string
def git_version():
Expand Down

6 comments on commit f217517

@87
Copy link
Contributor

@87 87 commented on f217517 Sep 20, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I guess it is not possible to merge #445 anymore?

@certik
Copy link
Contributor Author

@certik certik commented on f217517 Sep 20, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry, I'll merge it before rc1. I just want to get the beta2 out, so that people can test it.

@87
Copy link
Contributor

@87 87 commented on f217517 Sep 20, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok, I was a bit worried about the API change. Thanks!

@teoliphant
Copy link
Member

@teoliphant teoliphant commented on f217517 Sep 20, 2012 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@87
Copy link
Contributor

@87 87 commented on f217517 Sep 20, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that depends.. I added a new function to nditer_api.c, NpyIter_IsScalar, which tells if the iterator output is a scalar. That function had to be added to numpy_api.py to be able to build it, which, according to the docs, changes the API. It would not be an issue as long as the API for 1.7 isn't frozen, which I was not sure about. Technically, it could be possible to bypass NpyIter_IsScalar, but that would not lead to a clean solution..

@certik
Copy link
Contributor Author

@certik certik commented on f217517 Sep 20, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss it on the PR page.

Please sign in to comment.