You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The unravel_index() function takes an argument named dims that corresponds to:
The shape of the array to use for unraveling indices.
It seems like in most other places, this argument would be named shape, so I propose to rename it to match that convention, unless there is some special reason for this name to be different.
The text was updated successfully, but these errors were encountered:
I agree that shape is a better name, but we need to not break code that calls np.unravel_index(inds, dims=(...,)). The easiest way to do that in the C code is something like:
* unravel_index() now supports the shape argument
(Fixesnumpy#10586) while retaining backwards compatibility
for the dims argument
* added corresponding unit tests and docstring
changes
* updated compatibility release notes
The
unravel_index()
function takes an argument nameddims
that corresponds to:It seems like in most other places, this argument would be named
shape
, so I propose to rename it to match that convention, unless there is some special reason for this name to be different.The text was updated successfully, but these errors were encountered: