Source link in doc of printoptions goes to contextlib

[kohr-h]

The source link in the documentation of the new printoptions context manager has the wrong link target: it goes to the invalid

http://github.com/anaconda3/lib/python3.6/contextlib.py#L281-L311

Seems like an issue with the link auto-generation machinery, maybe even with other decorated functions?

[eric-wieser]

I think this might be a sphinx bug, assuming we're using sphinx.ext.linkcode

[eric-wieser]

Nope, this is a bug in our own code - good find!

numpy/doc/source/conf.py

Lines 303 to 348 in 83828f5

	def linkcode_resolve(domain, info):
	"""
	Determine the URL corresponding to Python object
	"""
	if domain != 'py':
	return None
	modname = info['module']
	fullname = info['fullname']
	submod = sys.modules.get(modname)
	if submod is None:
	return None
	obj = submod
	for part in fullname.split('.'):
	try:
	obj = getattr(obj, part)
	except Exception:
	return None
	try:
	fn = inspect.getsourcefile(obj)
	except Exception:
	fn = None
	if not fn:
	return None
	try:
	source, lineno = inspect.getsourcelines(obj)
	except Exception:
	lineno = None
	if lineno:
	linespec = "#L%d-L%d" % (lineno, lineno + len(source) - 1)
	else:
	linespec = ""
	fn = relpath(fn, start=dirname(numpy.__file__))
	if 'dev' in numpy.__version__:
	return "https://github.com/numpy/numpy/blob/master/numpy/%s%s" % (
	fn, linespec)
	else:
	return "https://github.com/numpy/numpy/blob/v%s/numpy/%s%s" % (
	numpy.__version__, fn, linespec)

In particular, inspect.getsourcefile will not behave usefully on a contextlib contextmanager. inspect.unwrap should solve that problem

[eric-wieser]

This relates to https://bugs.python.org/issue1764286

[kohr-h]

Wow, that was quick! Interesting that it turned up an inconsistency in the Python standard library.

[eric-wieser]

Upstream fix at python/cpython#8602

[eric-wieser]

Upstream fix still waiting for review - I think a review from a non core developer would move the process forwards