Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get typing tests to work on Python 3.9 #16538

Closed
person142 opened this issue Jun 9, 2020 · 1 comment · Fixed by #16613
Closed

Get typing tests to work on Python 3.9 #16538

person142 opened this issue Jun 9, 2020 · 1 comment · Fixed by #16613

Comments

@person142
Copy link
Member

The typing tests currently fail on Python 3.9 and mypy 0.770. It's possible that upgrading mypy to the recently-released 0.780 will fix the issue as it has some fixes for 3.9, e.g. python/mypy#8716

Reproducing code example:

Do a

$ ./runtests.py -s tests

on Python 3.9.

Error message:

The tests will have many errors of the form:

E               ValueError: Unexpected reveal line format: /home/travis/build/numpy/numpy/builds/venv/lib/python3.9/site-packages/numpy/__init__.pyi:53: error: syntax error in type comment

(which seem potentially related to the issue linked above).

Numpy/Python version information:

  • NumPy version: 1.20.0.dev0+f09b27d
  • This is on Python 3.9, though I'm relaying errors seen in CI (haven't set up 3.9 locally yet)
@person142
Copy link
Member Author

(Adding the 1.20.0 milestone to make sure I look into this before the release.)

person142 added a commit to person142/numpy that referenced this issue Jun 16, 2020
Closes numpy#16538.

This allows us to run mypy in CI against Python 3.9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant