Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: Finalize the deprecation of np.typeDict? #17585

Closed
BvB93 opened this issue Oct 19, 2020 · 2 comments · Fixed by #17586
Closed

DEP: Finalize the deprecation of np.typeDict? #17585

BvB93 opened this issue Oct 19, 2020 · 2 comments · Fixed by #17586

Comments

@BvB93
Copy link
Member

BvB93 commented Oct 19, 2020

The np.typeDict dictionary is currently marked as a deprecated alias for np.sctypeDict:

# backwards compatibility --- deprecated name
typeDict = sctypeDict

The thing is, it has been marked as such over 14 years (6689502). Can it be removed at this point?

@eric-wieser
Copy link
Member

I'd be in favor of deprecating it using the module level __getattr__ in numpy/__init__.py.

@BvB93
Copy link
Member Author

BvB93 commented Oct 19, 2020

That would definitely be the safer option, especially since I don't think it's mentioned anywhere outside of that single comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants