Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #92.
The proposed alternative
numpy.sctypeDict
seems to be discouraged in numpy/numpy#17585.Based on our relatively shallow current usage of
numpy.typeDict
:mdp-toolkit/mdp/utils/routines.py
Line 295 in 300d288
I propose to replace
numpy.typeDict[d]
by the genericnumpy.dtype(d).type
as:This change to a function (as opposed to dictionary) has the downside of having to exclude the check:
mdp-toolkit/mdp/utils/routines.py
Line 297 in 300d288
However, we learn that exactly 2 of the current 5 checks will return
false
in the most recent release of numpy as of 03/27/22:I excluded the invalid ones and dropped the check. I think it is likely this will not create problems down the line.
General note:
I am not sure the functionality of checking for unsafe types generically is still up-to-date. Especially as it is only run if one is not using
scipy.linalg.eigh
:mdp-toolkit/mdp/utils/routines.py
Line 286 in 300d288