Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker build failed. #19830

Closed
charris opened this issue Sep 6, 2021 · 3 comments
Closed

Docker build failed. #19830

charris opened this issue Sep 6, 2021 · 3 comments

Comments

@charris
Copy link
Member

charris commented Sep 6, 2021

See https://github.com/numpy/numpy/actions/runs/1204103327. Might be related to the documentation build changes.

@mattip
Copy link
Member

mattip commented Sep 6, 2021

It seems to be something in setup.py with the regexp that looks into FULLVERSION

#14 [build 4/5] RUN conda activate numpy-dev &&     python setup.py build_ext --inplace &&     ccache -s
#14 1.387 Traceback (most recent call last):
#14 1.387   File "/workspace/numpy/setup.py", line 58, in <module>
#14 1.387     MAJOR, MINOR, MICRO = re.match(r'(\d+)\.(\d+)\.(\d+)', FULLVERSION).groups()
#14 1.388 AttributeError: 'NoneType' object has no attribute 'groups'
#14 ERROR: process "/bin/bash --login -o pipefail -c conda activate ${CONDA_ENV} &&     python setup.py build_ext --inplace &&     ccache -s" did not complete successfully: exit code: 1

@mattip
Copy link
Member

mattip commented Sep 6, 2021

So something is wrong with the way the conda env is picking up the FULLVERSION

numpy/setup.py

Lines 50 to 60 in b3a66e8

FULLVERSION = versioneer.get_version()
# Capture the version string:
# 1.22.0.dev0+ ... -> ISRELEASED == False, VERSION == 1.22.0
# 1.22.0rc1+ ... -> ISRELEASED == False, VERSION == 1.22.0
# 1.22.0 ... -> ISRELEASED == True, VERSION == 1.22.0
# 1.22.0rc1 ... -> ISRELEASED == True, VERSION == 1.22.0
ISRELEASED = re.search(r'(dev|\+)', FULLVERSION) is None
MAJOR, MINOR, MICRO = re.match(r'(\d+)\.(\d+)\.(\d+)', FULLVERSION).groups()
VERSION = '{}.{}.{}'.format(MAJOR, MINOR, MICRO)

@rgommers
Copy link
Member

This CI job has been green for a while, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants