Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Fix ob_shash deprecation warning on Python 3.11 #21317

Closed
felixxm opened this issue Apr 10, 2022 · 0 comments · Fixed by #21321
Closed

BUG: Fix ob_shash deprecation warning on Python 3.11 #21317

felixxm opened this issue Apr 10, 2022 · 0 comments · Fixed by #21321
Labels
00 - Bug

Comments

@felixxm
Copy link
Contributor

felixxm commented Apr 10, 2022

Describe the issue:

ob_shash is deprecated on Python 3.11:

numpy/core/src/multiarray/scalarapi.c:709:13: warning: ‘ob_shash’ is deprecated [-Wdeprecated-declarations]

This looks unnecessary 🤔, cached hash value for obj should not be computed yet:

numpy/numpy/core/src/multiarray/scalarapi.c

Line 709 in 28e624d

((PyBytesObject *)obj)->ob_shash = -1;

Reproduce the code example:

Run tests on Python 3.11.

Error message:

numpy/core/src/multiarray/scalarapi.c:709:13: warning: ‘ob_shash’ is deprecated [-Wdeprecated-declarations]

NumPy/Python version information:

1.23.0.dev0+1020.g08569fcf0 3.8.10 (default, Mar 15 2022, 12:22:08)
[GCC 9.4.0]
felixxm added a commit to felixxm/numpy that referenced this issue Apr 11, 2022
@felixxm
BUG: Stop using PyBytesObject.ob_shash deprecated in Python 3.11, see n…
b5214da 
…umpy#21317.

This is unnecessary because a cached hash value should not be computed
for obj. Moreover PyBytesObject.ob_shash was deprecated in Python 3.11.
@mattip mattip closed this as completed in 17c1c5e Apr 21, 2022
mattip added a commit that referenced this issue Apr 21, 2022
@mattip
Merge pull request #21321 from felixxm/fix-21317
1686141 
BUG: Stop using PyBytesObject.ob_shash deprecated in Python 3.11, fixes #21317.
charris pushed a commit to charris/numpy that referenced this issue May 5, 2022
@felixxm @charris
BUG: Stop using PyBytesObject.ob_shash deprecated in Python 3.11, fixes
710fbbd 
numpy#21317.

PyBytesObject.ob_shash was deprecated in Python 3.11.
This was referenced May 5, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
00 - Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BUG: Stop using PyBytesObject.ob_shash deprecated in Python 3.11. felixxm/numpy
1 participant
@felixxm