Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: 1.8.1 openblas not found #4607

Closed
sashkab opened this issue Apr 9, 2014 · 2 comments · Fixed by #4731
Closed

BUG: 1.8.1 openblas not found #4607

sashkab opened this issue Apr 9, 2014 · 2 comments · Fixed by #4731

Comments

@sashkab
Copy link

sashkab commented Apr 9, 2014

After back-porting #4191 into 1.8.1, openblas is not found on systems by default.

Backward compatibility logic is wrong.

diff --git a/numpy/distutils/system_info.py b/numpy/distutils/system_info.py
index fbdd164..35aba17 100644
--- a/numpy/distutils/system_info.py
+++ b/numpy/distutils/system_info.py
@@ -1565,7 +1565,7 @@ class openblas_info(blas_info):
         lib_dirs = self.get_lib_dirs()

         openblas_libs = self.get_libs('libraries', self._lib_names)
-        if openblas_libs == self._lib_names: # backward compat with 1.8.0
+        if openblas_libs == []: # backward compat with 1.8.0
             openblas_libs = self.get_libs('openblas_libs', self._lib_names)
         info = self.check_libs(lib_dirs, openblas_libs, [])
         if info is None:
@juliantaylor
Copy link
Contributor

looks more like a bug in system_info it sets the global default of the libraries keys to '' breaking the default setting of the get_libs function
workaround is to use the libraries key instead of the 1.8.0 only openblas_libs key which is deprecated.

@sashkab
Copy link
Author

sashkab commented Apr 10, 2014

Still, this is a bug, which needs to be addressed. Based on what I understood from the code, there is zero libraries which will get detected. Having both atlas and openblas installed on one of the systems, I was getting NOT FOUND for all.

juliantaylor added a commit to juliantaylor/numpy that referenced this issue May 22, 2014
the get_libs function assumes there is no default to return the default
it was asked to return in that case.
Closes numpygh-4607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants