ENH: Add capm to financial.py #11058
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
May 7, 2018
There was a problem hiding this comment.
I think there's a general reluctance to add new financial functions to numpy: #2880.
|
|
||
| """ | ||
| try: | ||
| rf >= 1 or rm >= 1: |
There was a problem hiding this comment.
oops! I missed out the if statement there.
There was a problem hiding this comment.
"I think there's a general reluctance to add new financial functions to numpy: #2880."
Does it mean contributing to the finance library is void for now?
There was a problem hiding this comment.
@olamilekan000 indeed. I've added a comment to gh-2880 to that effect.
| ke = rf + beta * (rm - rf) | ||
| return ke | ||
| except Exception as e: | ||
| raise e |
There was a problem hiding this comment.
This try/except can be removed
|
@olamilekan000 thank you for contributing. we don't want to accept new financial functions, hence I'm closing this PR. We do appreciate your efforts though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just added capm to financial.py