TST: Fix urlopen stubbing. #11776
Merged
TST: Fix urlopen stubbing. #11776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setup/teardown doesn't work, but setup_module/teardown_module does, at least in pytest.
charris
added
00 - Bug
05 - Testing
component: numpy.lib
08 - Backport
jeffyancey
approved these changes
Aug 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #11715.
For whatever reason, this stubbing does not do anything. I think it is because the
class setup overrides the module setup, but I did not look into it too deeply. Renaming
setuptosetup_moduleandteardowntoteardown_modulefixes that.