BUG: Dealloc cached buffer info (#12249) #12296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* BUG: clear buffer_info_cache on scalar dealloc * MAINT: preemptively call _array_dealloc_buffer_info as soon as possible * BUG: also remove cached info for scalars * MAINT: refactor _array_dealloc_buffer_info-> _dealloc_cached_buffer_info
charris
added
00 - Bug
component: numpy._core
08 - Backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #12249.
Fixes #12122.
577dbbd, added in 2009 for numpy 1.5 to fix TRAC issue 1312 worked around a deficiency in that "PyArg_ParseTuple("s#", ...) refuses to return a buffer if bf_releasebuffer is present". That changeset never released a buffer_info_cache entry for a scalar. This fixes that problem. Note also cpython issue 24009 where they discuss deprecating "s#" parsing.
It is difficult to test this fix since the cache keys are id(value) and the cache is static in buffer.c. We should revisit the need for the cache, it seems like there should be a better way.
Edit: note that the issue number predates github, formatting
BUG: clear buffer_info_cache on scalar dealloc
MAINT: preemptively call _array_dealloc_buffer_info as soon as possible
BUG: also remove cached info for scalars
MAINT: refactor _array_dealloc_buffer_info-> _dealloc_cached_buffer_info