MAINT: Refactor sorting header file #12366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I assume the codecov report isn't making lots of sense here? |
eric-wieser
approved these changes
Nov 11, 2018
|
Thanks @liwt31 . |
The include file was made a couple of years before we started generating include files. The idea of generating it didn't even occur to me... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of adding timsort to numpy sorting algorithms #12186.
While trying to modify the header files related to sorting algorithms I find
numpy/core/src/common/npy_sort.his verbose and hard-coded. It might be a better idea to use a templatenumpy/core/src/common/npy_sort.h.src(the main part of this PR) to generate the file when building numpy.BTW some lines in
.gitignorelabeled as# Things specific to this project #seem outdated. Maybe this should be filed in another issue?