BUG: Fix build for glibc on ARC and uclibc. #13137
Conversation
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> [Retrieved (and slightly updated) from: https://git.buildroot.net/buildroot/tree/package/python-numpy/0001-no-fenv-on-uclibc.patch] Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
The FPU exceptions bits are missing in fenv.h in glibc for ARC architecture. Signed-off-by: Evgeniy Didin <Evgeniy.Didin@synopsys.com> [Retrieved (and slightly updated) from: https://git.buildroot.net/buildroot/tree/package/python-numpy/0003-no-FPU-exceptions-bits-on-ARC-glibc.patch] Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
charris
changed the title
charris
changed the title
|
@ffontaine I assume you have tested this on the relevant platforms, is that correct? |
|
Nope, it was only build-tested, not runtime tested. However, I assume that the original patches that we have on buildroot on python-numpy in version 1.15.2 was runtime tested by their original authors. I tried to backport these patches to make them work with latest master. However, if you think the changes are incorrect, I can also disable python-numpy on uclibc and glibc arc on buildroot. |
|
Build testing is probably adequate. I assume the problem with testing is that you are cross compiling.
What project is that? |
|
Buildroot (https://buildroot.org) is an open source project that allows users to easily build their embedded Linux systems through cross-compilation. |
|
OK, let's give it a shot. The only thing that concerns me is that ARC or uclibc might update in the future and we will have no way to know. Guess if that happens we will need a version check in anycase. LGTM seems stalled, so merging this instead of waiting. Thanks @ffontaine . |
fenv.h is not available on uclibc, arc architecture on glibc does not support FPU exceptions