DOC: show workaround for backward compatibility #13985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattip
added
04 - Documentation
09 - Backport-Candidate
eric-wieser
reviewed
Jul 14, 2019
|
|
||
| .. code-block:: python | ||
|
|
||
| func = getattr(rg, 'integers', getattr(rg, 'randint', None)) |
There was a problem hiding this comment.
getattr(rg, 'integers', None) or rg.randint would be safer and faster. Frankly I'd encourage the longer more readable form:
try:
rg_integers = rg.integers
except AttributeError:
rg_integers = rg.randint
There was a problem hiding this comment.
I think Eric's last version is an improvement.
|
Not waiting on the CI here, shippable is way behind gobbling up merges. Thanks Matti. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #13945
Document a workaround for using code to span pre-1.17 versions