Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Missing warnings import in polyutils #13989

Merged
merged 4 commits into from
Jul 14, 2019
Merged

BUG: Missing warnings import in polyutils #13989

merged 4 commits into from
Jul 14, 2019

Conversation

patto90
Copy link
Contributor

@patto90 patto90 commented Jul 14, 2019

warning module was used but not imported in numpy.polynomials.polyutils. Tests were not catching this bug.

  • Increase test coverage to trigger and check the RankWarning (including check of error message)
  • Add missing import statement

@charris charris changed the title Missing import polyutils BUG: Missing import in polyutils Jul 14, 2019
@charris charris added the 09 - Backport-Candidate PRs tagged should be backported label Jul 14, 2019
@charris charris added this to the 1.17.0 release milestone Jul 14, 2019
@charris charris changed the title BUG: Missing import in polyutils BUG: Missing warnings import in polyutils Jul 14, 2019
@charris charris merged commit e02cdee into numpy:master Jul 14, 2019
@charris
Copy link
Member

charris commented Jul 14, 2019

Thanks @patto90 .

@charris charris mentioned this pull request Jul 14, 2019
Merged
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Jul 14, 2019
@charris charris removed this from the 1.17.0 release milestone Jul 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
00 - Bug component: numpy.polynomial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@patto90 @charris @tylerjereddy