REV: "ENH: Improved performance of PyArray_FromAny for sequences of array-like" #14109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I cannot say I am super happy with reverting, but it does seem like the easiest solution if we want to release quickly unfortunately. |
…rray-like" This reverts commit 71fc59d which was part of numpygh-13399 and the followup commit ba53a63 from numpygh-13663. The issue is that we mix Sequence protocol and `__array__` usage when coercing arrays. It seems easiest to revert this for the 1.17.x release and make a larger breaking change in the 1.18.x release cycle. Since this only occurs for stranger array-likes. This revert is limited to the 1.17.x branch for now.
seberg
force-pushed
the
revert-arraylike-coerce-speedup
branch
from
875a8c4
to
4045da3
Compare
seberg
commented
Jul 24, 2019
| "data": bytes(42) | ||
| } | ||
|
|
||
| # Make sure __array_*__ is used instead of Sequence methods. |
There was a problem hiding this comment.
Nvm. Removed the test for now, because __iter__ is now used again (tripping this assertion).
charris
added
06 - Regression
09 - Backport-Candidate
|
A simple reversion would be easiest for 1.17. |
|
@charris you mean make this against master instead? I guess that is better, otherwise keeping track of it gets harder. |
|
Probably fine to keep this against 1.17 as long as an issue for 1.18 is opened. |
|
OK, let's do this. We can revisit at leisure. Thanks Sebastian. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 71fc59d
which was part of gh-13399 and the followup commit
ba53a63 from gh-13663.
The issue is that we mix Sequence protocol and
__array__usagewhen coercing arrays. It seems easiest to revert this for the 1.17.x release
and make a larger breaking change in the 1.18.x release cycle.
Since this only occurs for stranger array-likes. This revert is limited
to the 1.17.x branch for now.
@charris do you think such a revert is feasible? I have removed the benchmark and test changes from the revert. The PR was a bit of nice maintenance as well, but it seems to me that full revert is "simpler".