DEP: remove deprecated select behaviour #14583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe the file should be |
mattip
force-pushed
the
select-deprecation
branch
from
7678c95
to
fa3ff5b
Compare
seberg
reviewed
Sep 23, 2019
| "convert to bools." | ||
| warnings.warn(msg, DeprecationWarning, stacklevel=3) | ||
| raise ValueError( | ||
| 'invalid entry {} in condlist: should be boolean ndarray'.format(i)) |
There was a problem hiding this comment.
Should this be a TypeError? "Expired" is great, and right now they are all formatted as bullets too (whidch I think works well for the expired ones). Sorry to make this abit of a rabbit hole, but unless there are obvious tests elsewhere, they should probably be morpfed into assert_raises...
mattip
force-pushed
the
select-deprecation
branch
from
fa3ff5b
to
65e91e4
Compare
seberg
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref gh-11521. This behaviour was deprecated in NumPy 1.9.
I am not sure about how we refer to expired deprecations. "Remove", "Resolve", "Retire" ?