BUG: clear only attribute errors in get_attr_string.h::maybe_get_attr

numpy/core/src/common/get_attr_string.h

@@ -39,6 +39,14 @@ _is_basic_python_type(PyTypeObject *tp)
     );
 }
 
+static NPY_INLINE void
+clear_exception(PyObject *exception)
+{
+    if (PyErr_Occurred() && PyErr_ExceptionMatches(exception)) {
+        PyErr_Clear();
+    }
+}
+
 /*
  * Stripped down version of PyObject_GetAttrString,
  * avoids lookups for None, tuple, and List objects,
@@ -63,7 +71,7 @@ maybe_get_attr(PyObject *obj, char *name)
     if (tp->tp_getattr != NULL) {
         res = (*tp->tp_getattr)(obj, name);
         if (res == NULL) {
-            PyErr_Clear();
+            clear_exception(PyExc_AttributeError);
         }
     }
     /* Attribute referenced by (PyObject *)name */
@@ -79,7 +87,7 @@ maybe_get_attr(PyObject *obj, char *name)
         res = (*tp->tp_getattro)(obj, w);
         Py_DECREF(w);
         if (res == NULL) {
-            PyErr_Clear();
+            clear_exception(PyExc_AttributeError);
         }
     }
     return res;

numpy/core/src/multiarray/ctors.c

@@ -2351,7 +2351,11 @@ PyArray_FromStructInterface(PyObject *input)
 
     attr = PyArray_LookupSpecial_OnInstance(input, "__array_struct__");
     if (attr == NULL) {
-        return Py_NotImplemented;
+        if (PyErr_Occurred()) {
+            return NULL;
+        } else {
+            return Py_NotImplemented;
+        }
     }
     if (!NpyCapsule_Check(attr)) {
         goto fail;

numpy/core/tests/test_issue14735.py

@@ -0,0 +1,51 @@
+import pytest
+import warnings
+import numpy as np
+
+
+class Wrapper:
+    def __init__(self, array):
+        self.array = array
+
+    def __len__(self):
+        return len(self.array)
+
+    def __getitem__(self, item):
+        return type(self)(self.array[item])
+
+    def __getattr__(self, name):
+        if name.startswith("__array_"):
+            warnings.warn("object got converted", UserWarning)
+
+        return getattr(self.array, name)
+
+    def __repr__(self):
+        return f"<Wrapper({self.array})>"
+
+@pytest.mark.filterwarnings("error")
+def test_pint_replica_warning():
+    array = Wrapper(np.arange(10))
+    with pytest.raises(UserWarning, match="object got converted"):
+        np.asarray(array)
+
+def test_pint_replica():
+    print(np.__version__)
+
+    array = Wrapper(np.arange(10))
+    with warnings.catch_warnings():
+        warnings.filterwarnings("ignore")
+        expected = np.asarray(array)
+
+    with warnings.catch_warnings():
+        warnings.filterwarnings("error")
+        try:
+            actual = np.asarray(array)
+        except UserWarning:
+            print("user warning caught")
+            actual = expected
+
+    assert (
+        type(expected) == type(actual)
+        and expected.dtype == actual.dtype
+        and np.allclose(expected, actual)
+    )