BUG: add endfunction, endsubroutine to valid fortran end words #15035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattip
commented
Dec 3, 2019
| @@ -542,7 +542,7 @@ | |||
| 'ARRSIZE'] = '#define ARRSIZE(dims,rank) (_PyArray_multiply_list(dims,rank))' | |||
| cppmacros['OLDPYNUM'] = """\ | |||
| #ifdef OLDPYNUM | |||
| #error You need to install NumPy version 13 or higher. See https://scipy.org/install.html | |||
| #error You need to install NumPy version 0.13 or higher. See https://scipy.org/install.html | |||
eric-wieser
reviewed
Dec 3, 2019
eric-wieser
reviewed
Dec 3, 2019
|
|
||
| def test_module(self): | ||
| k = np.array([1, 2, 3], dtype = np.float) | ||
| w = np.array([1, 2, 3], dtype = np.float) |
There was a problem hiding this comment.
Let's not make #6103 worse ;)
Suggested change
| w = np.array([1, 2, 3], dtype = np.float) | |
| w = np.array([1, 2, 3], dtype=float) |
eric-wieser
reviewed
Dec 3, 2019
| k = np.array([1, 2, 3], dtype = np.float) | ||
| w = np.array([1, 2, 3], dtype = np.float) | ||
| k = np.array([1, 2, 3], dtype = np.float64) | ||
| w = np.array([1, 2, 3], dtype = np.float64) |
There was a problem hiding this comment.
PEP8 says no spaces around = here, as in my suggested change
eric-wieser
approved these changes
Dec 3, 2019
|
@melissawm maybe you can give a hand at reviewing this? |
|
Sure, just give me a few days since I'm a bit busy at work right now, if that's ok! |
|
Thanks everyone for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test, fix for missing end words in fortran subroutines and functions.
Fixes gh-14625