MAINT: Delete numpy.distutils.compat #15255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
force-pushed
the
remove-numpy.distutils.compat
branch
from
4b7a1c1
to
c9da1e0
Compare
|
touching |
eric-wieser
force-pushed
the
remove-numpy.distutils.compat
branch
from
c9da1e0
to
27ce08b
Compare
|
Updated with a release note. |
`get_exception` has no callers as of this commit's parent, and is hard to argue as public API given the only docstring in the file refers to "inside distutils".
eric-wieser
force-pushed
the
remove-numpy.distutils.compat
branch
from
27ce08b
to
679c834
Compare
|
Thanks @eric-wieser |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_exceptionhas no callers as of this commit's parent (gh-15248), and is hard to argue as public API given the only docstring in the file refers to "inside distutils".This compat layer has been unnecessary since Python 2.5 (final release 8.5 years ago), which numpy has not supported since 1.7.0 (released 6 years ago).