DOC: Disclaimer for FFT library #17028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Aside from the extended set of functions provided, |
|
@grlee77 That's a good point; "superset" while technically true doesn't really convey scipy's bigger scope. Reworded it to call scipy "more comprehensive". Hopefully the reader can take a hint. |
Adds sentence to the top of routines.fft.html explaining that scipy.fft is a more comprehensive collection, per mailing list discussion (http://numpy-discussion.10968.n7.nabble.com/Add-Chebyshev-cosine-transforms-implemented-via-FFTs-td48373.html#a48382)
rgommers
force-pushed
the
fft-disclaimer
branch
from
7d96ac7
to
8a92eb4
Compare
|
+1 for both. Great idea to add a link. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds sentence to the top of
routines.fft.htmlexplaining thatscipy.fftis a more comprehensive collection, per mailing list discussion
(http://numpy-discussion.10968.n7.nabble.com/Add-Chebyshev-cosine-transforms-implemented-via-FFTs-td48373.html#a48382)