MAINT: Move the np.core.numeric annotations to their own stub file
#17474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 7, 2020 00:07
Prevents mypy crashes related to import cycles. See numpy#17316
BvB93
commented
Oct 7, 2020
| char, | ||
| compat, | ||
| core, |
|
Thanks @BvB93 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request moves the
numericannotations to their own dedicated stub file.The purpose of this PR is the same as #17309: cleaning up the main
__init__.pyifile a bit.Note that while there are some places where the functions' existing annotations can be improved,
such changes are beyond the scope of this PR; this is a simple copy/paste job.