MAINT: explicit disabling CCompilerOpt in F2PY
#17546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch also cleans up `CCompilerOpt` calls in build_ext and build_clib.
|
@melissawm, sorry for taking 4 ever. This patch is adding compiler defention compile options: '-DNPY_DISABLE_OPTIMIZATION=1 -I/tmp/tmp28kqexlt/src.linux-x86_64-3.6 -I/usr/local/lib/python3.6/dist-packages/numpy-1.20.0.dev0+fe77f46-py3.6-linux-x86_64.egg/numpy/core/include -I/usr/include/python3.6m -c'
x86_64-linux-gnu-gcc: /tmp/tmp28kqexlt/src.linux-x86_64-3.6/fib1module.c
x86_64-linux-gnu-gcc: /tmp/tmp28kqexlt/src.linux-x86_64-3.6/fortranobject.c |
|
I believe the CI failure is related to #17542 Otherwise, LGTM. Thanks, @seiko2plus ! |
|
Thanks @seiko2plus |
rgommers
added
the
component: SIMD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicit disabling
CCompilerOptin F2PYThis patch also cleans up
CCompilerOptcalls in build_ext and build_clib.closes #17321