Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: MAINT: Add NEP 43 links to NEP 42 #17558

Merged
merged 2 commits into from
Oct 14, 2020
Merged

Conversation

bjnath
Copy link
Contributor

@bjnath bjnath commented Oct 14, 2020

Now that NEP 43 is merged, adds the missing NEP 43 links to NEP 42.

@mattip
Copy link
Member

mattip commented Oct 14, 2020

Could these be

:ref:`NEP 43`

instead of

:ref:`NEP 43 <NEP43>`

Rather than saying 'NEP 4x', the links
in the note at the top now include the NEP titles as well.
@bjnath
Copy link
Contributor Author

bjnath commented Oct 14, 2020

That doesn't work ("undefined label").

The link can be written :ref:`NEP43` (without the space) but then the NEP title is included. We don't want the title every time, just "NEP 43", which is the reason for the current coding.

OTOH, for the note at the top of the page, including the NEP titles seems a good idea, so I made that change.

@mattip
Copy link
Member

mattip commented Oct 14, 2020

We probably had the same discussion before, thanks for reminding me 👍 The rendered page looks good.

@mattip mattip merged commit a5aae4f into numpy:master Oct 14, 2020
@mattip
Copy link
Member

mattip commented Oct 14, 2020

Thanks @bjnath

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants