MAINT: Update the annotations in np.core.numeric
#17564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 14, 2020 16:57
* Added missing overloads * Use `DtypeLike` and `_Shapelike` where applicable * Moved a few annotation-aliases to the top of the module
BvB93
commented
Oct 14, 2020
| @overload | ||
| def count_nonzero( | ||
| a: ArrayLike, axis: None = ..., *, keepdims: Literal[False] = ... | ||
| ) -> int: ... |
There was a problem hiding this comment.
A bit odd that one overload returns a builtin int and the other one a numpy signedinteger (or an array).
See #17562.
BvB93
commented
Oct 14, 2020
| ) -> ndarray: ... | ||
| def rollaxis(a: ArrayLike, axis: int, start: int = ...) -> ndarray: ... | ||
| def rollaxis(a: ndarray, axis: int, start: int = ...) -> ndarray: ... |
There was a problem hiding this comment.
As mentioned in the docs: rollaxis takes an array, not an array-like object.
`axes` can take either an integer or a 2-tuple of shape-like objects
|
Thanks @BvB93 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the annotations in
np.core.numericand adds a number of tests (which were previously absent).Generally speaking the updates fall in one of the following categories:
_CorrelateMode = Literal[...]) were moved to the top of the module.DtypeLikeor_Shapelike(when appropriate).fromfunctionandcount_nonzero).