ENH: Changed repr of np.bool_

[ganesh-k13]

Changes:

Changed repr of np.bool_

resolves #12950
refers: #5942, #7913

After Fix:

>>> str(np.bool_(False))
'numpy.False_'
>>> str(np.bool_(True))
'numpy.True_'
>>> 

Note:

I expect a lot of UT and Doc failures, will fix as we go along.

cc: @eric-wieser , @seberg

[ganesh-k13]

Some tests are forming cores, will send the mail to the mailing list, once that's fixed

[ganesh-k13]

Do macs have a different set of tests? I noticed this is failing.

[ganesh-k13]

It's working in linux:

(Pdb) p numpy_f
<function any at 0x7f78f15e7310>
(Pdb) p numpy_f(a, axis=1, keepdims=True)[...,:-1]
masked_array(
  data=[[[True, False, True]],

        [[True, False, True]]],
  mask=[[[False, False, False]],

        [[False, False, False]]],
  fill_value=numpy.True_)

> /home/ganesh/open-source/numpy/build/testenv/lib/python3.8/site-packages/numpy/ma/tests/test_core.py(4948)testkeepdims()
-> assert_equal(ma_f(a, keepdims=True).shape,
(Pdb) p ma_f(a, axis=1, keepdims=True)[...,:-1]
masked_array(
  data=[[[True, False, True]],

        [[True, False, True]]],
  mask=[[[False, False, False]],

        [[False, False, False]]],
  fill_value=numpy.True_)
(Pdb) p f
'any'

numpy/numpy/ma/tests/test_core.py

Lines 4958 to 4960 in 32f1359

	for f in ['sum', 'prod', 'mean', 'var', 'std']:
	testaxis(f, a, d)
	testkeepdims(f, a, d)

Any idea why it's failing only on Mac?

[eric-wieser]

The test that is failing is a documentation test, and I guess the documentation tests are only run on mac? You need to update the docstrings to use the new printing.

[mattip]

The incantation is python runtests.py -g --refguide-check

[ganesh-k13]

I have emailed the mailing list (nabble link, pipermail link)for their opinion @eric-wieser, as mentioned in the issue.

[eric-wieser]

Can you add an "improvements" release note, like we did when we improved void.__repr__ with https://numpy.org/doc/stable/release/1.14.0-notes.html#void-datatype-elements-are-now-printed-in-hex-notation?

[ganesh-k13]

@eric-wieser , any more changes needed?

[eric-wieser]

Looks good to me, and the mailing list seems not to care. Will leave this for another maintainer to push the button on if they agree.

I reworded the release note slightly to make clear also what did not change.

[ganesh-k13]

Thanks Eric, sure

[seberg]

Happy to put this in as such, although I wonder a bit whether this has the potential to be a slightly noisy transition, and 1.20 is already a big release.

[hameerabbasi]

This is different from every other NumPy scalar, np.int*, np.float*, ...

Also reprs don't usually include the module.

[seberg]

We are a bit unsure whether this is a good idea at all, could you propose this on the mailing list, since it is an API change?

[eric-wieser]

This already hit the mailing list and was meet with silence

[mattip]

Summarizing the current status:

• this PR should be retitled to reflect the pivot to changing the repr of all scalars
• tests are failing and it is still marked as a draft
• @eric-wieser could you remove your approval of the PR, it is confusing when looking at PR statuses.

[seberg]

The changes here were included in gh-22449 so closing this one.