BUG: mac dylib treated as part of extra objects by f2py #17611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbkumar
changed the title
mbkumar
changed the title
|
I am building a python extension using f2py to a library that has multiple
external libraries as dependencies. After successfully building the
extension on linux, I ran into issues on Mac. When I made the change to
f2py, the issue went away. So thought of pushing the fix to benefit the
wider community.
Bharat Medasani
Engineer
Princeton Plasma Physics Lab (PPPL)
…On Sun, Nov 1, 2020 at 8:19 AM Ralf Gommers ***@***.***> wrote:
***@***.**** approved this pull request.
That looks clearly correct, merging. Thanks @mbkumar
<https://github.com/mbkumar>. Can you comment on how you ran into this
issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#17611 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA62VEFHEHUT5BKHTXCEKNLSNVN7XANCNFSM4S3JKQ5A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.