Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fix some references #17619

Merged
merged 5 commits into from
Oct 24, 2020
Merged

DOC: Fix some references #17619

merged 5 commits into from
Oct 24, 2020

Conversation

takanori-pskq
Copy link

Related to #13114.

Comment on lines 816 to 819
Either :c:data:`PyUFunc_One`, :c:data:`PyUFunc_Zero`,
:c:data:`PyUFunc_None` or :c:data:`PyUFunc_AllOnes` to indicate
or :c:data:`PyUFunc_None` to indicate
the identity for this operation. It is only used for a
reduce-like call on an empty array.
Copy link
Member

@eric-wieser eric-wieser Oct 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps out of scope, but this is quite out of date - the full list is:

/*
* UFunc has unit of 0, and the order of operations can be reordered
* This case allows reduction with multiple axes at once.
*/
#define PyUFunc_Zero 0
/*
* UFunc has unit of 1, and the order of operations can be reordered
* This case allows reduction with multiple axes at once.
*/
#define PyUFunc_One 1
/*
* UFunc has unit of -1, and the order of operations can be reordered
* This case allows reduction with multiple axes at once. Intended for
* bitwise_and reduction.
*/
#define PyUFunc_MinusOne 2
/*
* UFunc has no unit, and the order of operations cannot be reordered.
* This case does not allow reduction with multiple axes at once.
*/
#define PyUFunc_None -1
/*
* UFunc has no unit, and the order of operations can be reordered
* This case allows reduction with multiple axes at once.
*/
#define PyUFunc_ReorderableNone -2
/*
* UFunc unit is an identity_value, and the order of operations can be reordered
* This case allows reduction with multiple axes at once.
*/
#define PyUFunc_IdentityValue -3

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@@ -15,7 +15,7 @@ Prerequisites
You'll need to know a bit of Python. For a refresher, see the `Python
tutorial <https://docs.python.org/tutorial/>`__.

To work the examples, you'll need `matplotlib` installed
To work the examples, you'll need ``matplotlib`` installed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To work the examples, you'll need ``matplotlib`` installed
To work the examples, you'll need :mod:`matplotlib` installed

assuming we have intersphinx set up.

takanori-pskq and others added 3 commits October 24, 2020 20:23
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@mattip mattip merged commit beac566 into numpy:master Oct 24, 2020
@mattip
Copy link
Member

mattip commented Oct 24, 2020

Thanks @takanori-pskq. Only 333 more warning to go until we can turn on -n

@takanori-pskq takanori-pskq deleted the i13114-fix-misc branch October 24, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants