Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLD: Lazy load f2py test utilities #17758

Merged
merged 1 commit into from Nov 12, 2020
Merged

BLD: Lazy load f2py test utilities #17758

merged 1 commit into from Nov 12, 2020

Conversation

virtuald
Copy link
Contributor

These are only used during testing. It's fine to load it while running the test because actually running the test can't be done while cross compiling. I haven't tested this at all... but I expect CI will break if it doesn't work.

Part of changes to support #17620 to prevent importing numpy during builds to support cross-compilation

Replaces #17730 and #17732.

This was referenced Nov 12, 2020
Closed
Closed
@virtuald
BLD: Lazy load f2py test utilities
25d579f 
These are only used during testing. It's fine to load it while running the test
because actually running the test can't be done while cross compiling.

Part of changes to support numpy#17620 to prevent importing numpy during builds to support cross-compilation
eric-wieser
eric-wieser approved these changes Nov 12, 2020
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you tested by hand that the attributes are still accessible?

@virtuald
Copy link
Contributor Author 

$ pip install numpy-1.20.0.dev0+25d579f-cp37-cp37m-linux_x86_64.whl
$ python
Python 3.7.9 (default, Aug 20 2020, 14:07:20) 
[GCC 10.2.1 20200723 (Red Hat 10.2.1-1)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from numpy.f2py import f2py_testing
>>> from numpy.f2py import test
>>>

@mattip mattip merged commit 44d66b8 into numpy:master Nov 12, 2020
@mattip
Copy link
Member

mattip commented Nov 12, 2020

Thanks @virtuald

@virtuald virtuald deleted the f2py-lazy-np branch November 12, 2020 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
36 - Build Build related PR component: numpy.f2py
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@virtuald @mattip @eric-wieser @charris