Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH, BLD: Define RISCV-32 support #17780

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ENH, BLD: Define RISCV-32 support #17780

wants to merge 1 commit into from

Conversation

kraj
Copy link
Contributor

@kraj kraj commented Nov 15, 2020

Helps compile on riscv32

Signed-off-by: Khem Raj raj.khem@gmail.com

@seberg seberg added the 36 - Build Build related PR label Nov 16, 2020
@seberg
Copy link
Member

seberg commented Nov 16, 2020

@kraj I think this should also be added to numpy/core/include/numpy/npy_endian.h. Does the full test suit pass with this patch? @aurel32 this may be a long shot, but since you added RISCV64, does this make sense to you?

@kraj
Copy link
Contributor Author

kraj commented Nov 16, 2020

@seberg so far I have only fixed build, I am in process of setting up a test run in qemu/riscv32

@kraj
Copy link
Contributor Author

kraj commented Nov 18, 2020

@seberg so far I have only fixed build, I am in process of setting up a test run in qemu/riscv32

I ran the tests

lib/tests/test_polynomial.py .................                                                                                                       [ 60%]
lib/tests/test_recfunctions.py .........................................x........                                                                    [ 60%]
lib/tests/test_regression.py ...........................                                                                                             [ 60%]
lib/tests/test_shape_base.py ..............................s...................................                                                      [ 61%]
lib/tests/test_stride_tricks.py ................                                                                                                     [ 61%]
lib/tests/test_twodim_base.py ..................................                                                                                     [ 61%]
lib/tests/test_type_check.py ....................................................                                                                    [ 62%]
lib/tests/test_ufunclike.py ......                                                                                                                   [ 62%]
lib/tests/test_utils.py ..............                                                                                                               [ 62%]
linalg/tests/test_build.py .                                                                                                                         [ 62%]
linalg/tests/test_deprecations.py Fatal Python error: Segmentation fault

Current thread 0x946f9010 (most recent call first):
  File "/usr/lib/python3.9/site-packages/numpy/linalg/linalg.py", line 969 in qr
  File "<__array_function__ internals>", line 5 in qr
  File "/usr/lib/python3.9/site-packages/numpy/testing/_private/utils.py", line 1789 in assert_warns
  File "/usr/lib/python3.9/site-packages/numpy/linalg/tests/test_deprecations.py", line 17 in test_qr_mode_full_future_warning
  File "/usr/lib/python3.9/site-packages/_pytest/python.py", line 184 in pytest_pyfunc_call
  File "/usr/lib/python3.9/site-packages/pluggy/callers.py", line 187 in _multicall
  File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 84 in <lambda>
  File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 93 in _hookexec
  File "/usr/lib/python3.9/site-packages/pluggy/hooks.py", line 286 in __call__
  File "/usr/lib/python3.9/site-packages/_pytest/python.py", line 1627 in runtest
  File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 163 in pytest_runtest_call
  File "/usr/lib/python3.9/site-packages/pluggy/callers.py", line 187 in _multicall
  File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 84 in <lambda>
  File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 93 in _hookexec
  File "/usr/lib/python3.9/site-packages/pluggy/hooks.py", line 286 in __call__
  File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 256 in <lambda>
  File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 310 in from_call
  File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 255 in call_runtest_hook
  File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 216 in call_and_report
  File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 127 in runtestprotocol
  File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 110 in pytest_runtest_protocol
  File "/usr/lib/python3.9/site-packages/pluggy/callers.py", line 187 in _multicall
  File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 84 in <lambda>
  File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 93 in _hookexec
  File "/usr/lib/python3.9/site-packages/pluggy/hooks.py", line 286 in __call__
  File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 338 in pytest_runtestloop
  File "/usr/lib/python3.9/site-packages/pluggy/callers.py", line 187 in _multicall
  File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 84 in <lambda>
  File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 93 in _hookexec
  File "/usr/lib/python3.9/site-packages/pluggy/hooks.py", line 286 in __call__
  File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 313 in _main
  File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 257 in wrap_session
  File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 306 in pytest_cmdline_main
  File "/usr/lib/python3.9/site-packages/pluggy/callers.py", line 187 in _multicall
  File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 84 in <lambda>
  File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 93 in _hookexec
  File "/usr/lib/python3.9/site-packages/pluggy/hooks.py", line 286 in __call__
  File "/usr/lib/python3.9/site-packages/_pytest/config/__init__.py", line 164 in main
  File "/usr/lib/python3.9/site-packages/numpy/_pytesttester.py", line 206 in __call__
  File "/usr/lib/python3-numpy/ptest/./run-ptest", line 4 in <module>
Segmentation fault

this is riscv32 emulation on qemu. So I might have to see whats going on.

@charris charris changed the title numpy/core: Define RISCV-32 support ENH, BLD: Define RISCV-32 support Nov 22, 2020
@charris
Copy link
Member

charris commented Jan 25, 2021

@kraj Any progress?

@kraj
Copy link
Contributor Author

kraj commented Jan 26, 2021

@charris I think the test results above hold, for my purposes its working ok.

Base automatically changed from master to main March 4, 2021 02:05
@kanavin
Copy link

kanavin commented Jan 3, 2022

@kraj this needs rebase on latest target commit

Helps compile on riscv32

Signed-off-by: Khem Raj <raj.khem@gmail.com>
@charris
Copy link
Member

charris commented Feb 19, 2023

close/reopen to see if Mac problem goes away.

@charris charris closed this Feb 19, 2023
@charris charris reopened this Feb 19, 2023
@charris
Copy link
Member

charris commented Feb 21, 2023

close/reopen

@charris charris closed this Feb 21, 2023
@charris charris reopened this Feb 21, 2023
@rossburton
Copy link

Successful CI run, is anything blocking this from merging?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Pending author's response
Development

Successfully merging this pull request may close these issues.

None yet

5 participants