DOC: Update release notes to mention type(dtype) is not np.dtype
#17914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seberg
force-pushed
the
update-release-notes
branch
from
7c30662
to
c0336df
Compare
seberg
commented
Dec 4, 2020
seberg
force-pushed
the
update-release-notes
branch
from
c0336df
to
e6d0a51
Compare
seberg
force-pushed
the
update-release-notes
branch
from
e6d0a51
to
716f6a4
Compare
This also requires mentioning the C-API macro `#define PyArray_DescrCheck(op) PyObject_TypeCheck(op, &PyArrayDescr_Type)` which was updated to the above in 1.16.6 meaning that using the macro and compiling against an older NumPy version will cause issues. The macro has to be avoided in that case.
seberg
force-pushed
the
update-release-notes
branch
from
716f6a4
to
d169276
Compare
|
Thanks Sebastian. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also requires mentioning the C-API macro
#define PyArray_DescrCheck(op) PyObject_TypeCheck(op, &PyArrayDescr_Type)which was updated to the above in 1.16.6 meaning that using the
macro and compiling against an older NumPy version will cause
issues. The macro has to be avoided in that case.