Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Removed empty String from Nag Compiler's Flags #17950

Merged
merged 3 commits into from
Dec 8, 2020

Conversation

Brunochris13
Copy link

The empty string caused errors when trying to install the sciPy library from source using the NAG's Fortran Compiler(nagfor).

Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this is fallout from when we switched from blind concatenation of flags to actually passing them as separate arguments to the compiler; and that we've seen this patch for other compilers too.

@charris charris merged commit bffb006 into numpy:master Dec 8, 2020
@charris
Copy link
Member

charris commented Dec 8, 2020

Thanks @Brunochris13 .

@ThemosTsikas
Copy link

Worth commenting here that the NAG Fortran Compiler has been fixed in development to ignore an empty argument. A warning will be issued by the compiler but it will not be interpreted as a source filename (e.g. ".f90") anymore. This will appear in the next Build 7040 of Release 7.0 of the Compiler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants