-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST, BUILD: Add a native x86 baseline build running on ubuntu-20.04 #17960
Conversation
b90e6e8
to
8f99906
Compare
to build and test NumPy against the maximum supported CPU features by the compiler and the running machine
e237327
to
3df3da1
Compare
/cc, @mattip |
This new run on ubuntu 20.04 uses the system python3.8 and cpu features
This is different from the github actions python3.8 run which is using cpu features and dispatching
Is there any concern that as azure changes its hardware we might see a different set of baseline features chosen? Thinking about it more, I guess if they change hardware, we could also have problems with dispatching, so this is no more "dangerous" than the current setup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only concern I have is the hidden cost of adding an additional CI run, we may want to limit our use of CI resources at some point.
Yes, that can normaly happens for example if the running machine only supports NumPy CPU features: SSE SSE2 SSE3 SSSE3 SSE41 POPCNT SSE42 AVX F16C FMA3 AVX2
No we don't,
But we still need to add another build for |
Thanks @seiko2plus |
Add a native x86 baseline build running on ubuntu-20.04
to build and test NumPy against the maximum supported CPU features
by the compiler and the running machine
native baseline build will allow us to test pull-requests like #17958,
that doesn't use runtime dispatching.