DOC: Add/remove spaces in snippets and re-format here and there #17976
Conversation
| >>> np.empty((2, 3)) # uninitialized, the result may vary | ||
| array([[3.73603959e-262, 6.02658058e-154, 6.55490914e-260], | ||
| [5.30498948e-313, 3.14673309e-307, 1.00000000e+000]]) |
There was a problem hiding this comment.
"may vary" is a special marker understood by our CI tools, I think you might need to put it back where it was (if CI fails).
There was a problem hiding this comment.
Interesting that this did not fail.
There was a problem hiding this comment.
This is failing in other PRs now, eg https://app.circleci.com/pipelines/github/numpy/numpy/5410/workflows/93d901be-60df-4a79-9d56-a35bdcc5b2f2/jobs/17498/parallel-runs/0/steps/0-106
| @@ -280,8 +280,8 @@ central part of the array and only prints the corners:: | |||
|
|
|||
| >>> print(np.arange(10000)) | |||
| [ 0 1 2 ... 9997 9998 9999] | |||
| >>> | |||
| >>> print(np.arange(10000).reshape(100,100)) | |||
| >>> | |||
There was a problem hiding this comment.
| >>> | |
| >>> |
otherwise someone's editor will just trim this again.
There was a problem hiding this comment.
This largely looks great, thanks!
My only objections would be subjective, that:
- Putting a trailing space after
>>>isn't helpful, it will probably be stripped in a later commit by accident - Spaces around
b**2asb ** 2etc seems unusual - I think some of the column alignment of comments was deliberate, but I don't feel strongly
doc/source/user/quickstart.rst
Outdated
| >>> c | ||
| array([20, 29, 38, 47]) | ||
| >>> b**2 | ||
| >>> b ** 2 |
There was a problem hiding this comment.
I'd be inclined to avoid spaces around **
BvB93
changed the title
|
@rnarkk Could you make the suggested fixes? |
|
Thanks @rnarkk |
|
HI, Thank you so much for providing helpful reviews.
Thank you! |
|
CI only passed because for some reason circle-ci did not run at all on this PR. |
No description provided.