SIMD: Optimize the performance of einsum's submodule sum. #18012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
Dec 17, 2020
seiko2plus
reviewed
Dec 23, 2020
seiko2plus
requested changes
Dec 23, 2020
Comment on lines
136
to
137
| const @temptype@ a01 = @from@(*data) + @from@(*(data + 1)); | ||
| const @temptype@ a23 = @from@(*(data + 2)) + @from@(*(data + 3)); |
There was a problem hiding this comment.
Suggested change
| const @temptype@ a01 = @from@(*data) + @from@(*(data + 1)); | |
| const @temptype@ a23 = @from@(*(data + 2)) + @from@(*(data + 3)); | |
| const @temptype@ a01 = @from@(*data) + @from@(data[1]); | |
| const @temptype@ a23 = @from@(data[2]) + @from@(data[3]); |
make it simpler?
| accum += a01 + a23; | ||
| } | ||
| #endif // !NPY_DISABLE_OPTIMIZATION | ||
| for (; count > 0; --count, data += 1) { |
There was a problem hiding this comment.
Suggested change
| for (; count > 0; --count, data += 1) { | |
| for (; count > 0; --count, ++data) { |
|
Thanks @Qiyu8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This is the sixth part of #17049 , The
sumoperation is extracted because three sub functions depends on it. The optimized code reduced the amount of code by 85%, the performance increased 45%~50% on X86 and about 14%~77% on ARM.Benchmark
Here is the ASV benchmark result.
SSE2 enabled
AV2 enabled
NEON enabled
System Info