DOC: Parameter name typo axes -> axis in numpy.fft._pocketfft. #18031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charris
reviewed
Dec 19, 2020
The parameter name seem to have a typo in both those case and reference axis (and not axes), this is likely due to copy-past as some other functions in this modules use axes (when several indices are required), but other also use `axis` and have the correct spelling. From review it also seem like previous phrasing is unclear so update all similar entries to reflect the new phrasing.
rgommers
approved these changes
Dec 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameter name seem to have a typo in both those case and reference
axis (and not axes), this is likely due to copy past as some other
functions in this modules use axes (when several indices are required),
but other also use
axisand have the correct spelling.From review it also seem like previous phrasing is unclear so update
all similar entries to reflect the new phrasing.