ENH: Add annotations for np.core.arrayprint
#18032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BvB93
commented
Dec 19, 2020
numpy/core/arrayprint.pyi
Outdated
| void: Callable[[void], str] | ||
| numpystr: Callable[[_CharLike], str] | ||
| object: Callable[[object], str] | ||
| str: Callable[[Any], str] # Unused but still present? |
There was a problem hiding this comment.
Done as of 82e5747.
Just to stress: the above-mentioned push does not deprecate anything,
it merely removes a few lines of unused code (and updates the docstring).
eric-wieser
reviewed
Dec 19, 2020
It's been non-functional for the past 8 years (xref numpy#459)
Co-Authored-By: Eric Wieser <425260+eric-wieser@users.noreply.github.com>
|
Thanks Bas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the title: this PR adds annotations for all array-printing-related functions in
np.core.arrayprint.@charris continuing from #7859 (comment):
The signature of
np.set_printoptionscan quite easily be annotated as it turns out,so annotations can definitely help here with aforementioned issue.