MAINT: exprtype regex simplify #18074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `determineexprtype_re_1` was modified to remove extraneous character class markers around a single `,` * a similar change was applied for the word metacharacter in `determineexprtype_re_2` and `determineexprtype_re_3` * the third character class in `determineexprtype_re_3` was simplified to remove an escape sequence--by placing the `-` at the start of the character class its metacharacter status can be avoided
charris
reviewed
Dec 27, 2020
| determineexprtype_re_3 = re.compile( | ||
| r'\A[+-]?[\d.]+[\d+\-de.]*(_(?P<name>[\w]+)|)\Z', re.I) | ||
| r'\A[+-]?[\d.]+[-\d+de.]*(_(?P<name>\w+)|)\Z', re.I) |
There was a problem hiding this comment.
I argue that moving - to be beginning of the set is marginally less readable, one more thing to remember :) But OK.
|
Thanks Tyler. The CircleCI tests seem to be running on your repo, do you have them enabled there? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
determineexprtype_re_1was modified to remove extraneouscharacter class markers around a single
,a similar change was applied for the word metacharacter
in
determineexprtype_re_2anddetermineexprtype_re_3the third character class in
determineexprtype_re_3wassimplified to remove an escape sequence--by placing the
-at the start of the character class its metacharacterstatus can be avoided