Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Fix exception cause in mingw32ccompiler.py #18109

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

PhanatosZou
Copy link
Contributor

This edit is in relation to issue #15986 .
Chained exception in:
mingw32ccompiler.py

@PhanatosZou
Copy link
Contributor Author

Kindly ask if anyone can review this PR? Any response will be appreciated!

@mattip
Copy link
Member

mattip commented Jan 8, 2021

This is really low on our priority list. If you wish to move forward with it, please relate to the last comment on the issue:

We would like to suggest that contributors show the output from the error. This will require you think about the error: is the code path actually hit? Does it make sense to chain the exception?

@seberg seberg changed the title Fix exception cause in mingw32ccompiler.py MAINT: Fix exception cause in mingw32ccompiler.py Jan 8, 2021
@seberg seberg merged commit 3dbf5ce into numpy:master Jan 8, 2021
@PhanatosZou
Copy link
Contributor Author

Thanks! @seberg @eric-wieser I'll give a thought about it. @mattip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants