MAINT: Changed the NBitBase
variancy in number
from co- to invariant
#18174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As was noted in #18128 (comment), the currently covariant nature of
np.number[~NBit_co]
caused the likes ofnp.float32
to be a sub-type ofnp.float64
, behavior that is very much undesirable.This PR attempts to fix aforementioned issue by making
np.number
invariant w.r.t. its numerical precision.Fortunately, this variancy change could be made quite safely and only a single test needed actual updating (08b32c3).
Examples
The behavior prior to this PR.